golden hour
/usr/share/perl5/pod
⬆️ Go Up
Upload
File/Folder
Size
Actions
a2p.pod
5.96 KB
Del
OK
perl.pod
15.43 KB
Del
OK
perl5004delta.pod
54.92 KB
Del
OK
perl5005delta.pod
33.48 KB
Del
OK
perl5100delta.pod
53.41 KB
Del
OK
perl5101delta.pod
42.86 KB
Del
OK
perl5120delta.pod
87.19 KB
Del
OK
perl5121delta.pod
9.91 KB
Del
OK
perl5122delta.pod
9.38 KB
Del
OK
perl5123delta.pod
4 KB
Del
OK
perl5124delta.pod
3.59 KB
Del
OK
perl5140delta.pod
140.94 KB
Del
OK
perl5141delta.pod
7.78 KB
Del
OK
perl5142delta.pod
6.73 KB
Del
OK
perl5143delta.pod
7.58 KB
Del
OK
perl5160delta.pod
130.52 KB
Del
OK
perl5161delta.pod
6 KB
Del
OK
perl5162delta.pod
3.51 KB
Del
OK
perl5163delta.pod
3.99 KB
Del
OK
perl561delta.pod
121.79 KB
Del
OK
perl56delta.pod
104.68 KB
Del
OK
perl581delta.pod
37.17 KB
Del
OK
perl582delta.pod
4.37 KB
Del
OK
perl583delta.pod
6.19 KB
Del
OK
perl584delta.pod
7.19 KB
Del
OK
perl585delta.pod
5.75 KB
Del
OK
perl586delta.pod
4.54 KB
Del
OK
perl587delta.pod
8.16 KB
Del
OK
perl588delta.pod
24.68 KB
Del
OK
perl589delta.pod
52.64 KB
Del
OK
perl58delta.pod
112.21 KB
Del
OK
perlaix.pod
18.77 KB
Del
OK
perlamiga.pod
6.87 KB
Del
OK
perlapi.pod
315.46 KB
Del
OK
perlapio.pod
18.88 KB
Del
OK
perlartistic.pod
6.85 KB
Del
OK
perlbeos.pod
2.87 KB
Del
OK
perlbook.pod
7.19 KB
Del
OK
perlboot.pod
183 B
Del
OK
perlbot.pod
182 B
Del
OK
perlbs2000.pod
7.73 KB
Del
OK
perlcall.pod
54.03 KB
Del
OK
perlce.pod
8.72 KB
Del
OK
perlcheat.pod
4.39 KB
Del
OK
perlclib.pod
7.5 KB
Del
OK
perlcn.pod
4.82 KB
Del
OK
perlcommunity.pod
6.29 KB
Del
OK
perlcygwin.pod
27.17 KB
Del
OK
perldata.pod
36.33 KB
Del
OK
perldbmfilter.pod
4.86 KB
Del
OK
perldebguts.pod
36.79 KB
Del
OK
perldebtut.pod
20.79 KB
Del
OK
perldebug.pod
38.15 KB
Del
OK
perldelta.pod
3.99 KB
Del
OK
perldgux.pod
2.75 KB
Del
OK
perldiag.pod
207.82 KB
Del
OK
perldos.pod
10.28 KB
Del
OK
perldsc.pod
24.84 KB
Del
OK
perldtrace.pod
6.21 KB
Del
OK
perlebcdic.pod
67.61 KB
Del
OK
perlembed.pod
35.21 KB
Del
OK
perlepoc.pod
3.57 KB
Del
OK
perlexperiment.pod
4.84 KB
Del
OK
perlfaq.pod
22.01 KB
Del
OK
perlfaq1.pod
13.52 KB
Del
OK
perlfaq2.pod
9.28 KB
Del
OK
perlfaq3.pod
37.46 KB
Del
OK
perlfaq4.pod
87.39 KB
Del
OK
perlfaq5.pod
54.11 KB
Del
OK
perlfaq6.pod
38.66 KB
Del
OK
perlfaq7.pod
36.35 KB
Del
OK
perlfaq8.pod
48.28 KB
Del
OK
perlfaq9.pod
14.71 KB
Del
OK
perlfork.pod
12.78 KB
Del
OK
perlform.pod
16.29 KB
Del
OK
perlfreebsd.pod
1.55 KB
Del
OK
perlfunc.pod
338.43 KB
Del
OK
perlgit.pod
29.75 KB
Del
OK
perlglossary.pod
110.66 KB
Del
OK
perlgpl.pod
13.54 KB
Del
OK
perlguts.pod
111.66 KB
Del
OK
perlhack.pod
35.03 KB
Del
OK
perlhacktips.pod
45.5 KB
Del
OK
perlhacktut.pod
6.07 KB
Del
OK
perlhaiku.pod
1.47 KB
Del
OK
perlhist.pod
43.32 KB
Del
OK
perlhpux.pod
28.07 KB
Del
OK
perlhurd.pod
1.94 KB
Del
OK
perlintern.pod
42.53 KB
Del
OK
perlinterp.pod
30 KB
Del
OK
perlintro.pod
22.08 KB
Del
OK
perliol.pod
33.03 KB
Del
OK
perlipc.pod
70.17 KB
Del
OK
perlirix.pod
4.29 KB
Del
OK
perljp.pod
7.57 KB
Del
OK
perlko.pod
7.52 KB
Del
OK
perllexwarn.pod
14.61 KB
Del
OK
perllinux.pod
1.45 KB
Del
OK
perllocale.pod
51.43 KB
Del
OK
perllol.pod
10.93 KB
Del
OK
perlmacos.pod
1001 B
Del
OK
perlmacosx.pod
10.4 KB
Del
OK
perlmod.pod
24.04 KB
Del
OK
perlmodinstall.pod
12.41 KB
Del
OK
perlmodlib.pod
78.49 KB
Del
OK
perlmodstyle.pod
20.76 KB
Del
OK
perlmpeix.pod
14.24 KB
Del
OK
perlmroapi.pod
3.13 KB
Del
OK
perlnetware.pod
6.35 KB
Del
OK
perlnewmod.pod
10.95 KB
Del
OK
perlnumber.pod
8.16 KB
Del
OK
perlobj.pod
33.65 KB
Del
OK
perlootut.pod
25.6 KB
Del
OK
perlop.pod
121.73 KB
Del
OK
perlopenbsd.pod
1.18 KB
Del
OK
perlopentut.pod
37.53 KB
Del
OK
perlos2.pod
90.53 KB
Del
OK
perlos390.pod
15.2 KB
Del
OK
perlos400.pod
4.51 KB
Del
OK
perlpacktut.pod
49.83 KB
Del
OK
perlperf.pod
50.05 KB
Del
OK
perlplan9.pod
5 KB
Del
OK
perlpod.pod
21.27 KB
Del
OK
perlpodspec.pod
66.2 KB
Del
OK
perlpolicy.pod
19.73 KB
Del
OK
perlport.pod
82.63 KB
Del
OK
perlpragma.pod
5.11 KB
Del
OK
perlqnx.pod
4.14 KB
Del
OK
perlre.pod
100.76 KB
Del
OK
perlreapi.pod
25.17 KB
Del
OK
perlrebackslash.pod
25.64 KB
Del
OK
perlrecharclass.pod
34.19 KB
Del
OK
perlref.pod
28.32 KB
Del
OK
perlreftut.pod
18.23 KB
Del
OK
perlreguts.pod
36 KB
Del
OK
perlrequick.pod
17.5 KB
Del
OK
perlreref.pod
14.19 KB
Del
OK
perlretut.pod
115.13 KB
Del
OK
perlriscos.pod
1.49 KB
Del
OK
perlrun.pod
49.58 KB
Del
OK
perlsec.pod
22.77 KB
Del
OK
perlsolaris.pod
28.63 KB
Del
OK
perlsource.pod
6.19 KB
Del
OK
perlstyle.pod
8.42 KB
Del
OK
perlsub.pod
55.15 KB
Del
OK
perlsymbian.pod
15.44 KB
Del
OK
perlsyn.pod
41.04 KB
Del
OK
perlthrtut.pod
45.41 KB
Del
OK
perltie.pod
37.02 KB
Del
OK
perltoc.pod
639 KB
Del
OK
perltodo.pod
362 B
Del
OK
perltooc.pod
183 B
Del
OK
perltoot.pod
183 B
Del
OK
perltrap.pod
40.28 KB
Del
OK
perltru64.pod
7.55 KB
Del
OK
perltw.pod
5.15 KB
Del
OK
perlunicode.pod
70.89 KB
Del
OK
perlunifaq.pod
13.31 KB
Del
OK
perluniintro.pod
35.44 KB
Del
OK
perluniprops.pod
229.74 KB
Del
OK
perlunitut.pod
7.76 KB
Del
OK
perlutil.pod
9.68 KB
Del
OK
perluts.pod
3.11 KB
Del
OK
perlvar.pod
69.19 KB
Del
OK
perlvmesa.pod
3.88 KB
Del
OK
perlvms.pod
51.33 KB
Del
OK
perlvos.pod
5.82 KB
Del
OK
perlwin32.pod
34.58 KB
Del
OK
perlxs.pod
71.66 KB
Del
OK
perlxstut.pod
48.52 KB
Del
OK
perlxstypemap.pod
22.97 KB
Del
OK
Edit: perlhacktut.pod
=encoding utf8 =for comment Consistent formatting of this file is achieved with: perl ./Porting/podtidy pod/perlhacktut.pod =head1 NAME perlhacktut - Walk through the creation of a simple C code patch =head1 DESCRIPTION This document takes you through a simple patch example. If you haven't read L<perlhack> yet, go do that first! You might also want to read through L<perlsource> too. Once you're done here, check out L<perlhacktips> next. =head1 EXAMPLE OF A SIMPLE PATCH Let's take a simple patch from start to finish. Here's something Larry suggested: if a C<U> is the first active format during a C<pack>, (for example, C<pack "U3C8", @stuff>) then the resulting string should be treated as UTF-8 encoded. If you are working with a git clone of the Perl repository, you will want to create a branch for your changes. This will make creating a proper patch much simpler. See the L<perlgit> for details on how to do this. =head2 Writing the patch How do we prepare to fix this up? First we locate the code in question - the C<pack> happens at runtime, so it's going to be in one of the F<pp> files. Sure enough, C<pp_pack> is in F<pp.c>. Since we're going to be altering this file, let's copy it to F<pp.c~>. [Well, it was in F<pp.c> when this tutorial was written. It has now been split off with C<pp_unpack> to its own file, F<pp_pack.c>] Now let's look over C<pp_pack>: we take a pattern into C<pat>, and then loop over the pattern, taking each format character in turn into C<datum_type>. Then for each possible format character, we swallow up the other arguments in the pattern (a field width, an asterisk, and so on) and convert the next chunk input into the specified format, adding it onto the output SV C<cat>. How do we know if the C<U> is the first format in the C<pat>? Well, if we have a pointer to the start of C<pat> then, if we see a C<U> we can test whether we're still at the start of the string. So, here's where C<pat> is set up: STRLEN fromlen; register char *pat = SvPVx(*++MARK, fromlen); register char *patend = pat + fromlen; register I32 len; I32 datumtype; SV *fromstr; We'll have another string pointer in there: STRLEN fromlen; register char *pat = SvPVx(*++MARK, fromlen); register char *patend = pat + fromlen; + char *patcopy; register I32 len; I32 datumtype; SV *fromstr; And just before we start the loop, we'll set C<patcopy> to be the start of C<pat>: items = SP - MARK; MARK++; sv_setpvn(cat, "", 0); + patcopy = pat; while (pat < patend) { Now if we see a C<U> which was at the start of the string, we turn on the C<UTF8> flag for the output SV, C<cat>: + if (datumtype == 'U' && pat==patcopy+1) + SvUTF8_on(cat); if (datumtype == '#') { while (pat < patend && *pat != '\n') pat++; Remember that it has to be C<patcopy+1> because the first character of the string is the C<U> which has been swallowed into C<datumtype!> Oops, we forgot one thing: what if there are spaces at the start of the pattern? C<pack(" U*", @stuff)> will have C<U> as the first active character, even though it's not the first thing in the pattern. In this case, we have to advance C<patcopy> along with C<pat> when we see spaces: if (isSPACE(datumtype)) continue; needs to become if (isSPACE(datumtype)) { patcopy++; continue; } OK. That's the C part done. Now we must do two additional things before this patch is ready to go: we've changed the behaviour of Perl, and so we must document that change. We must also provide some more regression tests to make sure our patch works and doesn't create a bug somewhere else along the line. =head2 Testing the patch The regression tests for each operator live in F<t/op/>, and so we make a copy of F<t/op/pack.t> to F<t/op/pack.t~>. Now we can add our tests to the end. First, we'll test that the C<U> does indeed create Unicode strings. t/op/pack.t has a sensible ok() function, but if it didn't we could use the one from t/test.pl. require './test.pl'; plan( tests => 159 ); so instead of this: print 'not ' unless "1.20.300.4000" eq sprintf "%vd", pack("U*",1,20,300,4000); print "ok $test\n"; $test++; we can write the more sensible (see L<Test::More> for a full explanation of is() and other testing functions). is( "1.20.300.4000", sprintf "%vd", pack("U*",1,20,300,4000), "U* produces Unicode" ); Now we'll test that we got that space-at-the-beginning business right: is( "1.20.300.4000", sprintf "%vd", pack(" U*",1,20,300,4000), " with spaces at the beginning" ); And finally we'll test that we don't make Unicode strings if C<U> is B<not> the first active format: isnt( v1.20.300.4000, sprintf "%vd", pack("C0U*",1,20,300,4000), "U* not first isn't Unicode" ); Mustn't forget to change the number of tests which appears at the top, or else the automated tester will get confused. This will either look like this: print "1..156\n"; or this: plan( tests => 156 ); We now compile up Perl, and run it through the test suite. Our new tests pass, hooray! =head2 Documenting the patch Finally, the documentation. The job is never done until the paperwork is over, so let's describe the change we've just made. The relevant place is F<pod/perlfunc.pod>; again, we make a copy, and then we'll insert this text in the description of C<pack>: =item * If the pattern begins with a C<U>, the resulting string will be treated as UTF-8-encoded Unicode. You can force UTF-8 encoding on in a string with an initial C<U0>, and the bytes that follow will be interpreted as Unicode characters. If you don't want this to happen, you can begin your pattern with C<C0> (or anything else) to force Perl not to UTF-8 encode your string, and then follow this with a C<U*> somewhere in your pattern. =head2 Submit See L<perlhack> for details on how to submit this patch. =head1 AUTHOR This document was originally written by Nathan Torkington, and is maintained by the perl5-porters mailing list.
Save