golden hour

/opt/cpanel/perl5/536/site_lib/Perl/Critic/Policy/BuiltinFunctions

File/Folder	Size	Actions
ProhibitBooleanGrep.pm	4.52 KB
ProhibitComplexMappings.pm	3.94 KB
ProhibitLvalueSubstr.pm	3.37 KB
ProhibitReverseSortBlock.pm	3.51 KB
ProhibitShiftRef.pm	4.71 KB
ProhibitSleepViaSelect.pm	2.73 KB
ProhibitStringyEval.pm	7.1 KB
ProhibitStringySplit.pm	3.08 KB
ProhibitUniversalCan.pm	2.9 KB
ProhibitUniversalIsa.pm	3.01 KB
ProhibitUselessTopic.pm	5.62 KB
ProhibitVoidGrep.pm	2.53 KB
ProhibitVoidMap.pm	2.53 KB
RequireBlockGrep.pm	2.8 KB
RequireBlockMap.pm	2.64 KB
RequireGlobFunction.pm	2.24 KB
RequireSimpleSortBlock.pm	2.99 KB

Edit: RequireSimpleSortBlock.pm

package Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock;

use 5.010001;
use strict;
use warnings;
use Readonly;

use Perl::Critic::Utils qw{ :severities :classification };
use parent 'Perl::Critic::Policy';

our $VERSION = '1.152';

#-----------------------------------------------------------------------------

Readonly::Scalar my $DESC => q{Sort blocks should have a single statement};
Readonly::Scalar my $EXPL => [ 149 ];

#-----------------------------------------------------------------------------

sub supported_parameters { return ()                                   }
sub default_severity     { return $SEVERITY_MEDIUM                     }
sub default_themes       { return qw( core pbp maintenance complexity) }
sub applies_to           { return 'PPI::Token::Word'                   }

#-----------------------------------------------------------------------------

sub violates {
    my ( $self, $elem, undef ) = @_;

return if $elem->content() ne 'sort';
    return if ! is_function_call($elem);

my $sib = $elem->snext_sibling();
    return if !$sib;

my $arg = $sib;
    if ( $arg->isa('PPI::Structure::List') ) {
        $arg = $arg->schild(0);
        # Forward looking: PPI might change in v1.200 so schild(0) is a PPI::Statement::Expression
        if ( $arg && $arg->isa('PPI::Statement::Expression') ) {
            $arg = $arg->schild(0);
        }
    }
    return if !$arg || !$arg->isa('PPI::Structure::Block');

# If we get here, we found a sort with a block as the first arg
    return if ( 1 >= $arg->schildren() );

# more than one child statements
    return $self->violation( $DESC, $EXPL, $elem );
}

#-----------------------------------------------------------------------------

__END__

=pod

=head1 NAME

Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock - Sort blocks should have a single statement.

=head1 AFFILIATION

This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.

=head1 DESCRIPTION

Conway advises that sort functions should be simple.  Any complicated
operations on list elements should be computed and cached (perhaps via
a Schwartzian Transform) before the sort, rather than computed inside
the sort block, because the sort block is called C<N log N> times
instead of just C<N> times.

This policy prohibits the most blatant case of complicated sort
blocks: multiple statements.  Future policies may wish to examine the
sort block in more detail -- looking for subroutine calls or large
numbers of operations.

=head1 CONFIGURATION

This Policy is not configurable except for the standard options.

=head1 AUTHOR

Chris Dolan <cdolan@cpan.org>

=head1 COPYRIGHT

This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself.

=cut

# Local Variables:
#   mode: cperl
#   cperl-indent-level: 4
#   fill-column: 78
#   indent-tabs-mode: nil
#   c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :