golden hour

/opt/cpanel/perl5/536/site_lib/Perl/Critic/Policy/BuiltinFunctions

File/Folder	Size	Actions
ProhibitBooleanGrep.pm	4.52 KB
ProhibitComplexMappings.pm	3.94 KB
ProhibitLvalueSubstr.pm	3.37 KB
ProhibitReverseSortBlock.pm	3.51 KB
ProhibitShiftRef.pm	4.71 KB
ProhibitSleepViaSelect.pm	2.73 KB
ProhibitStringyEval.pm	7.1 KB
ProhibitStringySplit.pm	3.08 KB
ProhibitUniversalCan.pm	2.9 KB
ProhibitUniversalIsa.pm	3.01 KB
ProhibitUselessTopic.pm	5.62 KB
ProhibitVoidGrep.pm	2.53 KB
ProhibitVoidMap.pm	2.53 KB
RequireBlockGrep.pm	2.8 KB
RequireBlockMap.pm	2.64 KB
RequireGlobFunction.pm	2.24 KB
RequireSimpleSortBlock.pm	2.99 KB

Edit: ProhibitVoidGrep.pm

package Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep;

use 5.010001;
use strict;
use warnings;
use Readonly;

use Perl::Critic::Utils qw{ :severities :classification is_in_void_context };
use parent 'Perl::Critic::Policy';

our $VERSION = '1.152';

#-----------------------------------------------------------------------------

Readonly::Scalar my $DESC => q{"grep" used in void context};
Readonly::Scalar my $EXPL => q{Use a "for" loop instead};

#-----------------------------------------------------------------------------

sub supported_parameters { return ()                     }
sub default_severity     { return $SEVERITY_MEDIUM       }
sub default_themes       { return qw( core maintenance ) }
sub applies_to           { return 'PPI::Token::Word'     }

#-----------------------------------------------------------------------------

sub violates {
    my ( $self, $elem, undef ) = @_;

return if $elem->content() ne 'grep';
    return if not is_function_call($elem);
    return if not is_in_void_context($elem);

return $self->violation( $DESC, $EXPL, $elem );
}

__END__

#-----------------------------------------------------------------------------

=pod

=head1 NAME

Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep - Don't use C<grep> in void contexts.

=head1 AFFILIATION

This Policy is part of the core L<Perl::Critic|Perl::Critic>
distribution.

=head1 DESCRIPTION

C<map> and C<grep> are intended to be pure functions, not mutators.
If you want to iterate with side-effects, then you should use a proper
C<for> or C<foreach> loop.

grep{ print frobulate($_) } @list;           #not ok
    print map{ frobulate($_) } @list;            #ok

grep{ $_ = lc $_ } @list;                    #not ok
    for( @list ){ $_ = lc $_  };                 #ok

map{ push @frobbed, frobulate($_) } @list;   #not ok
    @frobbed = map { frobulate($_) } @list;      #ok

=head1 CONFIGURATION

This Policy is not configurable except for the standard options.

=head1 AUTHOR

Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>

=head1 COPYRIGHT

This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself.  The full text of this license
can be found in the LICENSE file included with this module.

=cut

# Local Variables:
#   mode: cperl
#   cperl-indent-level: 4
#   fill-column: 78
#   indent-tabs-mode: nil
#   c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :